dev/core#1651 and dev/core#1637 - Inline editing not working on many admin screens and other js packages issues

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/issues/1651

Go to any admin screen with option value-like entries, like phone types or activity types. Try to click on one of the inline-editable fields. Nothing happens.

Also https://lab.civicrm.org/dev/core/issues/1637 for related issues with kcfinder and mailing screen.

Technical Details

This commit changed something and in a default stock install the url gets formed incorrectly: 3130950#diff-db0ac48007cde9731cada1cf69334517

Comments

If it's not obvious the regex removes any trailing slashes that might already be there, then the slash gets added as part of the following string.

Affects 5.23.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kcristiano]

Tested on 5.24 with WP and D7. I tested this as a standalone PR and did not apply #16780

Did an r-run and tested adding mailing images, browsing from the server in a mailing and inline editing.

All were successful with this PR. I am getting a failure on #16780 and have noted that in that PR

[kcristiano]

as detailed in #16780 this PR is preferred and we should merge to 5.24 and 5.23 as it is a regression

[seamuslee001]

Merging as per review by @kcristiano