Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] cleanup financial type form - remove complex inheritence #16777

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor cleanup - as with #16776

Before

Form inherits from CRM_Contribute_Form

After

Form inherits from CRM_Core_Form

Technical Details

Inheriting from 2 intermediary forms adds complexity with little benefit. Since we have the entityFormTrait
this increases use of that

Comments

Inheriting from 2 intermediary forms adds complexity  with little benefit. Since  we have the entityFormTrait
this increases use of that
@civibot civibot bot added the master label Mar 14, 2020
@civibot
Copy link

civibot bot commented Mar 14, 2020

(Standard links)

@colemanw
Copy link
Member

Change makes sense. Tested it out on the demo site and form works as expected.

@colemanw colemanw merged commit 301b2fe into civicrm:master Mar 15, 2020
@colemanw colemanw deleted the ftype_form branch March 15, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants