[REF] cleanup financial type form - remove complex inheritence #16777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor cleanup - as with #16776
Before
Form inherits from CRM_Contribute_Form
After
Form inherits from CRM_Core_Form
Technical Details
Inheriting from 2 intermediary forms adds complexity with little benefit. Since we have the entityFormTrait
this increases use of that
Comments