dev/core#1637 - Multiple fixes for Civi/Core/Paths.php #16745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Add tests."" This reverts commit cbcbfd6.
…URLs without trailing /
When browsing the list of outputs from this test class, each of the test cases was identified by its numerical position in the list of `$exs`. This makes it hard to keep track of the failures. 1. Add a symbolic name to each case (that's easier to search on) 2. Add more verbose output for failed assertions
The rationale will be discussed more via PR description.
For a full write-up, see PR
The interpretation of `/.` is evolving per civicrm#16735: * When this code was first written, it was unspecified/variable whether the value `[foo]/.` would end in `/` * During most of the testing of 5.23.beta1, this was defined to always return `/` * During a regression fix in 5.23.1, we're flipping it back the other way so that `[foo]/.` never ends in `/`.
Per 16735, the interpretation of `getPath('[foo]/.`)` changed
slightly - from:
* 5.22: Inconsistent/undefined tail end (may or may not have trailing `/`)
* 5.23.0: Defined to always end with `/`
* civicrm#16735: Defined to never end with `/`
|
(Standard links)
|
|
Jenkins re test this please |
|
Test fail unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16735 from 5.24 (RC) to 5.23 (stable).
On local WP build of this branch, the Civi-WP URLs looks correct (
admin.phpnotadmin.php/), and specifically-mentioned unit-tests (E2E/Core/*andCivi/Core/PathsTest.php) run OK.