Contribution Summary Report: Taking the currency filtered in the "gen…

[muniodiego]

…eral total" row. Implements dev/report#27

Overview

Contribution Summary Report: Taking the currency filtered in the "general total" row

Before

When the contribution summary report is used by filtering for a currency other than the site's default currency, the "grand total" row shows the sign of the default currency instead of the filtered currency.

After

Technical Details

Comments

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@lucianov88 this looks like something you might be interested in reviewing?

[eileenmcnaughton]

I tested this and it works in this scenario but it is still flawed - without the filter I think it would use the currency of the last donation (& they are all jumbled in together. However, the same approach is used elsewhere within the file so it is at least consistent - as well as solving this specific scenario.

Obviously I'd prefer a test but I think this can be viewed as a standardisation & sneak through