Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1637 - Multiple fixes for Civi/Core/Paths.php #16735

Merged
merged 7 commits into from
Mar 11, 2020
Merged

dev/core#1637 - Multiple fixes for Civi/Core/Paths.php #16735

merged 7 commits into from
Mar 11, 2020

Commits on Mar 10, 2020

  1. Revert "Revert "Make $civicrm_paths less sensitive to trailing slashe… 

    …s. Add tests.""

This reverts commit cbcbfd6.
    @totten
    totten committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    aee09ef View commit details
    Browse the repository at this point in the history

  2. (NFC) dev/core#1637 - Add E2E test for generation of Civi-WP backend … 

    …URLs without trailing /
    @totten
    totten committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    8e0dabd View commit details
    Browse the repository at this point in the history

  3. (NFC) PathsTest - Make it easier to identify/debug test cases 

    When browsing the list of outputs from this test class, each of the test
cases was identified by its numerical position in the list of `$exs`.  This
makes it hard to keep track of the failures.

1. Add a symbolic name to each case (that's easier to search on)
2. Add more verbose output for failed assertions
    @totten
    totten committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    715cee3 View commit details
    Browse the repository at this point in the history

  4. dev/core#1637 - PathsTest - Redefine "[foo]/", "[foo]/0", "[foo]/." 

    The rationale will be discussed more via PR description.
    @totten
    totten committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    021f851 View commit details
    Browse the repository at this point in the history

  5. dev/core#1637 - Multiple fixes for Civi/Core/Paths.php 

    For a full write-up, see PR
    @totten
    totten committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b66d559 View commit details
    Browse the repository at this point in the history

  6. CRM_Core_I18n - Fix usage of getPath('[foo]/.') 

    The interpretation of `/.` is evolving per civicrm#16735:

* When this code was first written, it was unspecified/variable whether the value `[foo]/.` would end in `/`
* During most of the testing of 5.23.beta1, this was defined to always return `/`
* During a regression fix in 5.23.1, we're flipping it back the other way so that `[foo]/.` never ends in `/`.
    @totten
    totten committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f64df9e View commit details
    Browse the repository at this point in the history

  7. E2E_Extern_CliRunnerTest - Update to match change in ./ 

    Per 16735, the interpretation of `getPath('[foo]/.`)` changed
slightly - from:

* 5.22: Inconsistent/undefined tail end (may or may not have trailing `/`)
* 5.23.0: Defined to always end with `/`
* civicrm#16735: Defined to never end with `/`
    @totten
    totten committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    0d4d8d5 View commit details
    Browse the repository at this point in the history