dev/core#1637 regression fix on WP urls

[eileenmcnaughton]

Overview

Reverts a change in 5.23 that is causing url breakage on WP when clean urls are not enabled (https://lab.civicrm.org/dev/core/issues/1637) and possibly Joomla but
still checking that (https://lab.civicrm.org/dev/financial/issues/120)

Before

Generated url is
/wp-admin/admin.php/?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext

After

Generated url is /wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext

Technical Details

Revert "Make $civicrm_paths less sensitive to trailing slashes. Add t…ests."

This is currently causing breakage on wordpress sites where clean urls are not enabled.

Compare the 2 urls below - the top one has an extra (breaking) slash added by this PR.

I propose a quick revert & patch release followed by 'the right' fix at a slower pace
/wp-admin/admin.php/?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext
/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext

This reverts commit 232fdd3.

This is the relevant line https://github.com/civicrm/civicrm-core/pull/16404/files#diff-1544096e8e60bfe9fe73eeca2844804eR223

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kcristiano]

@eileenmcnaughton I did an r-run this does fix the trailing slash mentioned in Mattermost https://chat.civicrm.org/civicrm/pl/6kco13rhyigzxxa646a7gjt43r

Looks good to merge

edit: just noticed the failing tests. I am not sure how username could be related, but the prevnext may be.

It does not correct https://lab.civicrm.org/dev/core/issues/1637

[kcristiano]

I've just cleared caches and this may fix https://lab.civicrm.org/dev/core/issues/1637 Would appreciate another person testing

[christianwach]

This is currently causing breakage on wordpress sites where clean urls are not enabled.

Also when Clean URLs are enabled.

[christianwach]

Patch works after CiviCRM caches cleared as @kcristiano says.

[colemanw]

Unrelated test fails. Merging per review comments.