[REF] CRM_Utils_Array::value() -> empty() #16704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
force-pushed
the
arrayValue1
branch
2 times, most recently
from
b716053 to
7396bec
Compare
| @@ -546,7 +546,7 @@ public function preProcess() { | |||
|
|
|||
| // assign context to drive the template display, make sure context is valid | |||
| $this->_context = CRM_Utils_Request::retrieve('context', 'Alphanumeric', $this, FALSE, 'search'); | |||
| if (!CRM_Utils_Array::value($this->_context, self::validContext())) { | |||
| if (!array_key_exists($this->_context, self::validContext())) { | |||
There was a problem hiding this comment.
Theoretically these aren't equal. I don't see any code outside this class that manipulates the $_validContext property directly (which is what is returned by self::validContext()), and it seems unlikely anyone would do something screwy with it like change it to null, but it's a public property. Seems low risk though.
Replaces CRM_Utils_Array::value() with empty() when the value is immediately cast to boolean. The two statements have identical meaning but the latter is faster & easier to read.
|
Ok looks good I don't have anything more to add. |
|
test this please |
1 similar comment
|
test this please |
|
Unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replaces
CRM_Utils_Array::value()withempty()when the value is immediately cast to boolean.The two statements have identical meaning but the latter is faster & easier to read.
Technical Details
Before/after should be functionally identical.
Comments
This was done via regex with some spot-checking.