-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WordPress support for Get UF Locale #16700
Conversation
(Standard links)
|
I've got this on my site now for testing - so far so good! @christianwach it's failing on 10 style warnings - can you fix? |
@mattwire Have force pushed fixes -- let's see how the checks pan out. |
test this please |
Anyone have any ideas why the checks are failing? I see nothing amiss when I look at the details. |
jenkins test this please |
I restarted the test as I know there have been some oddities lately. |
Jenkins re test this please |
Thanks @kcristiano @christianwach |
Overview
This PR completes #16289 and solves the issue on Lab. In essence, CiviCRM only displays in the default CiviCRM language, whether on the front-end or in WordPress admin.
Before
When "Inherit language" is selected, CiviCRM only displays in the default language set in CiviCRM, whether on the front-end or in WordPress admin.
After
When "Inherit language" is selected, the logic that CiviCRM now follows is that: