dev/core#1366 - Case Audit.tpl file no longer used

[demeritcowboy]

Following #15998 this file never gets used anymore. There's no way to reach the (malfunctioning) javascripty interactive audit page anymore.

There's more that can be removed but keeping it small.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I'm going to merge this because I know it's a work in progress but I kinda feel it's starting at the wrong end - it's accessible from

civicrm-core/CRM/Case/XMLProcessor/Report.php

Lines 31 to 48 in a9410a6

	/**
	* @param int $clientID
	* @param int $caseID
	* @param string $activitySetName
	* @param array $params
	*
	* @return mixed
	*/
	public function run($clientID, $caseID, $activitySetName, $params) {
	$contents = self::getCaseReport($clientID,
	$caseID,
	$activitySetName,
	$params,
	$this
	);
	return CRM_Case_Audit_Audit::run($contents, $clientID, $caseID);
	}

but that function seems to be no longer accessed so removing this without removing that function first feels like the wrong order

[demeritcowboy]

You're right I should have done it the other way from a review standpoint. I'll do the other part tomorrow.

[eileenmcnaughton]

Thanks @demeritcowboy - you have a track record on following up on your commits so I was OK with merging in this order