CiviCase: fix case custom data values in Case Audit Report #16654
Conversation
|
(Standard links)
|
| } | ||
| } | ||
| } | ||
| $groupTree = CRM_Core_BAO_CustomGroup::getTree('Case', NULL, $caseID); |
There was a problem hiding this comment.
Need to include the case type in the getTree() call. Otherwise it doesn't show custom fields that are specific to that case type. See e.g. https://github.com/civicrm/civicrm-core/blob/5.22.1/CRM/Case/Form/CaseView.php#L146
| {foreach from=$group.fields item=row} | ||
| <tr> | ||
| <th class="label">{$row.field_title}</td> | ||
| <td class="crm-case-report-custom-field">{$row.field_value}</td> |
There was a problem hiding this comment.
These should be |escape'd, but I see it doesn't escape them on manage case either. Hmm.
mattwire
added
the
needs-work-not-review-ready
|
Betty and I are reviewing PRs and we came across this one. It has the label needs work and @demeritcowboy has given a review. @mlutfy are you still going to work on this PR? If not we would advice to close this PR. |
|
Thanks for the reminder. I'll try to have another look at it. |
|
@mlutfy I'll close this for now as it's needs-work + stale - please re-open when ready for review |
Overview
To reproduce:
The custom field will be printed in numeric form, instead of string.
Before
After
Technical Details
To be perfectly honest, these CustomData BAOs are pretty scary and I'm not sure I am using them correctly. 🤷♂️
cc @demeritcowboy