dev/core#1619 - Fatal error when grouping Activity Summary report by activity date

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/issues/1619
Run an activity summary civireport and on the grouping tab pick activity date. Pick any frequency. Gives a fatal error.

Before

Invalid query. Fatal error.

After

Query still invalid, but worked around by disabling ONLY_FULL_GROUP_BY.

Technical Details

ONLY_FULL_GROUP_BY

Comments

Adds a test.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I'm OK with this - we really should remove the handling for the group_by_freqs from this class & either extract in the parent class or just stop overriding SELECT()

However, this takes us forwards by adding testing!

[demeritcowboy]

Thanks!