Api4 - Display sql errors in explorer #16641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton test failures not related |
| * | ||
| * @return array|int | ||
| */ | ||
| function civicrm_api(string $entity, string $action, array $params, $extra = NULL) { | ||
| return \Civi::service('civi_api_kernel')->runSafe($entity, $action, $params, $extra); | ||
| function civicrm_api(string $entity, string $action, array $params) { |
There was a problem hiding this comment.
I had to search a bit for this but it does seem to have been some early on idea that didn't take off & it's not used in runSafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes display of debug info in Api4 Explorer.
Before
No sql shown for db_errors. And due to a json_encode problem, sometimes would show nothing at all.
After
Correctly shows backtrace & full sql for db_errors.