Remove unused columns from civicrm_saved_search #16637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
totten
reviewed
Feb 27, 2020
| } | ||
| if (preg_match('/contribution_type/', $dao->where_clause)) { | ||
| $saveDao->where_clause = preg_replace('/contribution_type/', 'financial_type', $dao->where_clause); | ||
| } |
There was a problem hiding this comment.
At what point did the columns become unused? Were they migrated to something else?
The reason I ask - it seems like this might affect the correctness of a DB upgrade that passes through v4.3?
Maybe that's OK. Maybe we could get away with bumping MINIMUM_UPGRADABLE_VERSION from 4.2 to 4.6?
There was a problem hiding this comment.
@totten looking at https://github.com/civicrm/civicrm-svn/search?p=1&q=where_clause&unscoped_q=where_clause It seems as tho it hasn't really been used at all.
|
@eileenmcnaughton can you add a line before the closing brace in |
|
Good to know these columns are unused. Makes future refactoring a little simpler. |
We identified these as unused in 5.20 & removed the places still saving to them - civicrm#14891 This removes the actual columns. A couple of other tables still have similar columns, not sure if they are required still
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unused db fields from civicrm_saved_search:
Before
fields exist, unused
After
fields removed
Technical Details
We identified these as unused in 5.20 & removed the places still saving to them -
#14891
This removes the actual columns. A couple of other tables still have similar columns, not sure
if they are required still
Comments
@colemanw