dev/core#1622 Fix unsubscribe when loading the unsubscribe form on a …

[seamuslee001]

…different locale to the one the mailing was sent from

Overview

This aims to fix a bug where by if you create and send mailing on locale 1 e.g. en_US but then load the unsubscribe form on locale 2 e.g. fr_FR the unsubscribe form does not show the correct list of groups.

Before

Incorrect list of groups shown if loading unsubscribe form on locale other than the locale used to send the mailing

After

Correct list of groups shown on unsubscribe form no matter the locale

Technical Details

The long and short of is we store the full translated table name in the entity_table and getTableName() will use the current locale to set the table name so if your on a different locale to the one the mailing was sent from then it breaks.

ping @eileenmcnaughton @artfulrobot @mlutfy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[artfulrobot]

Wow, good find @seamuslee001. I think it should work but a possible improvement might be to add comments about why the === matches the table names, and/or regex on /^civicrm_group(_.._..)$/ (untested) because the substring match also matches several other tables. I realise those are not relevant to the context, but probably deserves explanation.

[mlutfy]

I'm flabbergasted by the speed at which Seamus wrote the PR, and that it includes a test :)

[eileenmcnaughton]

@seamuslee001 I feel like this should be heavily commented as a temporary measure & we should plan to only store the non-translated table name

[seamuslee001]

@eileenmcnaughton i have added comments, is that sufficient?

[eileenmcnaughton]

@seamuslee001 yes I think so - would be nice to get that sillyness cleaned up