dev/core#1595 fix issue when using dedupe rule with custom field

[sluc23]

Overview

Fixes using dedupe rule when it includes custom field. It used to work until this strict civicrm_api3(string $entity, ..) definition was introduced in API v3 definition

Before

Execution of dedupe rule with custom field throws exception:

TypeError: Argument 1 passed to civicrm_api3() must be of the type string, null given, called in civicrm/CRM/Dedupe/BAO/Rule.php on line 62 in civicrm_api3() (line 84 of civicrm/api/api.php).

After

Execution dedupe rule with custom field works

Technical Details

Gitlab issue here
https://lab.civicrm.org/dev/core/issues/1595

Comments

This is a workaround to get this code block working, probably a deeper code refactor is needed here

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@sluc23 can you please test #16558 as i believe it will fix the issue as well

[eileenmcnaughton]

Closing as we merged (& released) a fix for this