dev/financial#118 Move source & receive date to the top on contribution view page #16565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on view page Per https://lab.civicrm.org/dev/financial/issues/118 this doesn't seem to be controversial - although there is a desire to take it further & once this is merged I'll look at that
|
(Standard links)
|
|
test this please |
|
@eileenmcnaughton looks good, can be merged. Are we waiting for further consensus? |
|
Merging per @yashodha review |
|
@yashodha I guess not :-) But the issue had 5+ & 0 against & with you that is 6-nil so it seems to be getting a clear response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Slight re-ordering of fields on contribution view - moves source & date to near the top
Before
After
Technical Details
Per https://lab.civicrm.org/dev/financial/issues/118 this doesn't seem to be controversial - although there is a desire
to take it further & once this is merged I'll look at that - ie the moving the fees block up
Comments
Double 'total amount' on before is unrelated