dev/financial#102 Extend test to check status #16564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
|
||
| // @todo fix Payment.create so it transitions appropriately & uncomment here. |
There was a problem hiding this comment.
These commented out lines were the main point of this
It turns out the code is working fine (fixed in the meantime?) and I just needed to extend the checks a bit, did some tangental cleanup
eileenmcnaughton
force-pushed
the
test
branch
from
5896a82 to
24b3dd9
Compare
|
Changes look good to me, Jenkins is happy with it merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test coverage extension
Before
Status checks commented out, no post integrity check, more use of CRM_Contribute_BAO_Contribution::getPaymentInfo which we hope to deprecate
After
Above improved
Technical Details
It turns out the code is working fine (fixed in the meantime?) and I just needed to extend the checks
a bit, did some tangental cleanup
Comments