Fix calls to Request::retrieve

[eileenmcnaughton]

Overview

Minor cleanup on calls to Request::retrieve

Before

Default params passed in, in some instances $_REQUEST is passed in - which is invalid but equivalent to not passing anything in. In some cases NULL object passed in

After

Where the defaults for the signature is used they are not also passed in

  public static function retrieve($name, $type, &$store = NULL, $abort = FALSE, $default = NULL, $method = 'REQUEST', $isThrowException = TRUE)

Technical Details

Do not pass in values that are set by default. Use retrieveValue rather than passing in the NULL object

Comments

@seamuslee001 I found more instances than this but didn't want to create a big PR that would be a pain to review - however, the thing I was searching for was whether the last parameter ($useException) is ever false - with a view to removing it if not. My searching suggests it can go

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please