Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 'billing address is the same' checkbox respond to the change event #16496

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Feb 7, 2020

Overview

Checking and unchecking the "My Billing Address is the same" only works if you actually "click" on the checkbox and not if you change it via any other method (eg. javascript). This makes it a little more robust so that it also responds to the change event. You can, for example, trigger change and it will update the billing fields if it is already checked.

Before

Does not always seem to work - difficult to know because the fields are hidden if it is checked.

After

Works in most cases. If the checkbox is "clicked" on or "changed" by any other method.

Technical Details

Described above.

Comments

Partial from #16488

@civibot
Copy link

civibot bot commented Feb 7, 2020

(Standard links)

@civibot civibot bot added the master label Feb 7, 2020
@jaapjansma
Copy link
Contributor

test this please

@mlutfy mlutfy merged commit 35844d6 into civicrm:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants