[REF] Remove patch from dompdf cleanup script that is no longer needed #16490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Codewise this looks right to me, comparing v0.8.3 and my local. I'm not clear how to reproduce the original error from the original jira but I'm not too worried. |
|
Nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This removes a patch that is now not needed. The patch was dompdf/dompdf@ad41b6d was included from v0.8.2 and we are on v0.8.3
Before
Patch duplicated in source code
After
Patch not duplicated
ping @eileenmcnaughton @totten @demeritcowboy