dev/core#1019 Calculate.tpl: fix the Total Amount currency formatting.

[mlutfy]

Overview

Gitlab: https://lab.civicrm.org/dev/core/issues/1019

On contribution forms where the Total Amount is displayed (ex with a Price Set), the Total Amount did not respect the locale's money format. This can yield weird results:

To replicate (copied from Gitlab):

• Go to Administer > Localization > Language and Currency Change Monetary Amount Display to %a %c
• Configure price sets with some amounts
• Use this price set for any event/contribution,etc each item will respect the amount display but not the total(since it is auto calculated)

Before

Broken.

After

• Formats the Total Amount correctly
• Removes the bold around the currency, since it makes no sense either.

Technical Details

• Removes code duplication.
• Two separate commits, one for the code reformatting.

Comments

Screenshot uses the taxcalculator extension, but it does not have an impact on the bug itself.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@mlutfy I tested this and seems to be working well

[yashodha]

@mlutfy I am merging this as this is working fine.