Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core#1568: Show recipientListing to non-admins #16455

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

MegaphoneJon
Copy link
Contributor

Overview

There's a bug report that the permissions were wrong when setting scheduled reminders as a non-administrator (via Manage Events) that you can't limit by participant role.

Before

Selection_796

After

Selection_797

Technical Details

There's no reason for this route to require Administer CiviCRM and is surely an artifact of the time before Scheduled Reminders were opened up to non-administrators.

@civibot
Copy link

civibot bot commented Feb 2, 2020

(Standard links)

@civibot civibot bot added the master label Feb 2, 2020
@jaapjansma
Copy link
Contributor

Betty and I are reviewing PR's and have reviewed this PR see below our findings.

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR and in the issue.
    • User impact (r-user)
      • PASS: A field which wasn't visible but should be visible is now visible again.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: We have tested the patch and it seems to work. We also tested whether the scheduled reminder did send the e-mail and everything seems to work.
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change does not require tests
    • Test results (r-test)
      • PASS: The test results are all-clear.

@mattwire we have reviewed this PR and we think it is good enough to merge it, can you merge this?

@mattwire mattwire merged commit c7e605d into civicrm:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants