[REF] Switch to using a non abandoned library for getting a mapping o…

[seamuslee001]

…f mimetpyes to extensions

Overview

As picked up by @stesi561 the current library we use for a mapping of mimetypes to file extensions is now abandoned this switches it to the library https://github.com/adrienrn/php-mimetyper

Before

Abandoned Library used

After

Non Abandoned library used

I believe that the unit tests added here 6cb3fe2#diff-bc35985bf1e1cabd25b2ad862413d38eR98 ensure that we have sufficient coverage to prevent a regression in this area

ping @eileenmcnaughton @totten

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[seamuslee001]

Jenkins re test this please

[yashodha]

@seamuslee001 the test failures don't look related.

[yashodha]

test this please

[seamuslee001]

Jenkins re test this please

[seamuslee001]

@eileenmcnaughton @totten @stesi561 I believe this is a fine drop in replacement can you folks confirm?

[stesi561]

I only see one reference to "\MimeType\Mapping" in the codebase. What else needs confirming?

[seamuslee001]

@stesi561 that you can still view attached files and that the contact image shows correctly on the contact summary screen

[mattwire]

@seamuslee001 Needs rebase

[seamuslee001]

rebased now @mattwire

[mlutfy]

Is the new library more actively maintained? or is it because of active/known bugs with the current lib?

• https://github.com/adrienrn/php-mimetyper Last commit: 2018-09-27
• https://github.com/katzien/PhpMimeType Last commit: 2017-03-02

[seamuslee001]

@mlutfy the katzien library is giving out a notice in composer saying it has been abaondoned hence the change

[seamuslee001]

@mlutfy "Package katzien/php-mime-type is abandoned, you should avoid using it. No replacement was suggested."

[mlutfy]

OK :)

Seems good to me, based on code review. Will try to do a quick test-run.

Jenkins, test this please.

[mlutfy]

I did a bit of poking around on the test site and looks good. Thanks @seamuslee001