dev/core#1113 - Decimal Separator - Invalid value "total_amount" (NaN,N) creating or editing a membership

[CsarRamos]

Overview

Invalid value in filed "total_amount" (NaN,N) when creating or editing a membership in some cases, more info here and steps to reproduce this error: https://lab.civicrm.org/dev/core/issues/1113

Before

If you dont remove the value (NaN,N) you cannot create or edit membreship.

After

The value is in correct format and you can create or edit a membership

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jitendrapurohit]

Hi @CsarRamos. I've just checked this PR and was able to replicate the issue from the steps mentioned on gitlab.

I see that an incorrect amount is displayed while creating the membership. To replicate,

• Click on Add Membership button.
• Select General mem type.
• The Amount in payment section is set to 100.000.000.000,00 instead of 100,00

This is after applying this PR and keeping the thousand separator value same as mentioned in https://lab.civicrm.org/dev/core/issues/1113.

Can you pls confirm?

[CsarRamos]

Hi @CsarRamos. I've just checked this PR and was able to replicate the issue from the steps mentioned on gitlab.

I see that an incorrect amount is displayed while creating the membership. To replicate,

• Click on Add Membership button.
• Select General mem type.
• The Amount in payment section is set to 100.000.000.000,00 instead of 100,00

This is after applying this PR and keeping the thousand separator value same as mentioned in https://lab.civicrm.org/dev/core/issues/1113.

Can you pls confirm?

Hi @jitendrapurohit, you're right, I'm sorry, now I update the pull request with a possible solution.

[eileenmcnaughton]

I tested this and it works - I'd rather a bigger clean up but that is definitely non-blocking on this.