dev/core#1486 Add index to civicrm_acl_cache.modified_date #16144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Dec 23, 2019
Despite being basically empty this table is involved in deadlocks frequently. I've added this index upstream civicrm/civicrm-core#16144 It should be super quick to run so won't require an outage. I'm looking into further ways to improve contention on this table https://lab.civicrm.org/dev/core/issues/1486 Bug: T182148 Change-Id: I82a1e9ca817326c1be1702e0d6189167d6c3f5a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds an index to the civicrm_acl_cache.modified_date column.
Existing installs will need to call System.updateindexes to benefit from this.
This should improve a query that commonly causes a deadlock - ie. DELETE FROM civicrm_acl_cache WHERE modified_date = .....
Before
No index
After
Ta da
Technical Details
Comments