[REF] simplify recordAdjustedAmt function

[eileenmcnaughton]

Overview

Makes IF statement more readable & casts to float to explicitly handle it

Before

Type of paidAmount is not explicit so when we change it to a float in getTotalPayments we could do something unexpected

After

Cast to float to be explicit. Also the IF is really confusing & it turns out it could be more readable by getting rid of the sill $skip & re-ordering the clauses.

Technical Details

Per #16129

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@eileenmcnaughton Do we need accompanying tests for this?

[eileenmcnaughton]

I'd hope we have some test cover on those functions as they are called all the time