Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1490 Fix syntax error in Membership Receipt #16121

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Dec 19, 2019

Overview

https://lab.civicrm.org/dev/core/issues/1490

To reproduce:

  • Setup a membership form, basic settings, with a test gateway so that billing fields are enabled
  • Enable email confirmation receipts

Result:

@civibot civibot bot added the 5.21 label Dec 19, 2019
@civibot
Copy link

civibot bot commented Dec 19, 2019

(Standard links)

@mattwire
Copy link
Contributor

I assume this is a result of all the message template changes in 5.20 @eileenmcnaughton Do we need to backport this to 5.20 / have an upgrader or anything?

@eileenmcnaughton
Copy link
Contributor

@mattwire yeah it would ideally be backported I guess it needs to be a point release specific upgrader line - depends where @totten is placed to do a last drop

@eileenmcnaughton eileenmcnaughton merged commit ca13c20 into civicrm:5.21 Dec 19, 2019
@eileenmcnaughton eileenmcnaughton deleted the core1490-rc branch December 19, 2019 20:18
@mlutfy
Copy link
Member Author

mlutfy commented Dec 19, 2019

I suspect not many people will run a point-release on December 20. They can edit their msg-tpl if it's an issue, or upgrade to 5.21 in January?

@eileenmcnaughton
Copy link
Contributor

yeah - I think if we do a release this should be in but it might not be enough to trigger one

@agileware-justin
Copy link
Contributor

Just hit this problem. Thanks @mlutfy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants