Payment PropertyBag: Add generic getter, setter methods for convenience #16081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In beginning to work with the new PropertyBag, we're realising some more sugar functions would be helpful.
Before
The only way to access properties was by knowing the getter's name; no way to "get if set otherwise give me a default".
After
You can use generic
getter()
and generic settersetter()
, optionally giving a default.Comments
Need discussed in #16052
Note: writing the tests for this threw up some interesting cases, esp. around custom property names and aliased property names (which you're not allowed to use because the only code using PropertyBag should know better!)