Remove unnecessary, and possibly incorrect query from email update #16079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
When updating an email the comments pretty clearly say to update bulkmail if it is 1 but the current if clause picks up anything other than 'null' - which is invalid for a boolean field. This creates an additional query which has some locking risk being in a high volume place. In addition it seems like it could be a bug in some cases
eileenmcnaughton
force-pushed
the
email
branch
from
6f1fb4c to
2ffdaed
Compare
| * | ||
| * @throws \CRM_Core_Exception | ||
| */ | ||
| public function testSetBulkEmail() { |
There was a problem hiding this comment.
@eileenmcnaughton what if you set the multiple billing settings so you end up with multiple bulk mailing emails or whatever it is?
There was a problem hiding this comment.
@seamuslee001 I didn't aim to cover all the scenarios - I think this is enough additional test cover for this change
|
Looks good. Tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes an unnecessary & possibly occasionally harmful query.
Before
Unnecessary query on each email update, possibly wrong outcome
After
Query only runs when it should - that scenario now tested
Technical Details
When updating an email the comments pretty clearly say to update bulkmail if it is 1 but the current if clause
picks up anything other than 'null' - which is invalid for a boolean field. This creates an additional query which has some
locking risk being in a high volume place. In addition it seems like it could be a bug in some cases
Comments