Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] code cleanup #16050

Merged
merged 1 commit into from
Dec 9, 2019
Merged

[NFC] code cleanup #16050

merged 1 commit into from
Dec 9, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Add some throws statements, fix some double quotes to single, fix some comparisons to strict

Before

Use of unnecessary double quotes, use not non strict comparisons

After

Per best practice singles uses where double are unnecessary, strict comparisons used - notably when we know one var is a string. Throws annotations added

Technical Details

Comments

Add some throws statements, fix some double quotes to single, fix some comparisons to strict
@civibot
Copy link

civibot bot commented Dec 9, 2019

(Standard links)

@civibot civibot bot added the master label Dec 9, 2019
@seamuslee001 seamuslee001 merged commit 2d7ad76 into civicrm:master Dec 9, 2019
@seamuslee001 seamuslee001 deleted the qf branch December 9, 2019 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants