Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Smart Group form unsets the existing Group Types #16043

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

jusfreeman
Copy link
Contributor

Overview

Update Smart Group form unsets the existing Group Types, which will cause the Group Type values to be lost when Smart Group is updated.

The screenshot below, Group has the Mailing List group type set.

chrome_VSWSDnbEJD

Before

When using the Update Smart Group form, it unsets the Mailing List group type.

chrome_0eM51qvWxM

After

With this PR, Mailing List group type remains set on the Update Smart Group form.

chrome_jNrGdwMgaF

Agileware Ref: CIVICRM-1391

@civibot
Copy link

civibot bot commented Dec 8, 2019

(Standard links)

@civibot civibot bot added the master label Dec 8, 2019
@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

  • General standards
    • (r-explain) Pass
    • (r-user) Pass
    • (r-doc) Pass
    • (r-run) Pass replicated the issue on my local dev and confirmed that for non mailing smart groups that the mailing list box remains unchecked
  • Developer standards

@seamuslee001 seamuslee001 merged commit 118e122 into civicrm:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants