Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow PCP report to filter on contribution status #16024

Merged

Conversation

jmcclelland
Copy link
Contributor

Without this filter, incomplete contributions are included in the report
which really throws off the total.

Overview

The PCP reports lists all PCP pages with total number of contributions made against each PCP page and total amount raised. Unfortunately, it totals all contributions, including cancelled ones.

Before

The totals for the PCP report are inaccurate becaues they include canceled contributions.

After

Now, users can filter based on contribution status to get the totals they want.

Without this filter, incomplete contributions are included in the report
which really throws off the total.
@civibot
Copy link

civibot bot commented Dec 3, 2019

(Standard links)

@civibot civibot bot added the master label Dec 3, 2019
@eileenmcnaughton
Copy link
Contributor

Tested this & it works. Change makes sense & is consistent with other reports

@eileenmcnaughton eileenmcnaughton merged commit d6ad19d into civicrm:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants