dev/core#1435 Fix lack of filtering in Contribution tab on Membership or Participant View #16013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or Participant View
|
(Standard links)
|
aydun
reviewed
Dec 3, 2019
| // an embedded block on ParticipantView or MembershipView. | ||
| $memberShipId = CRM_Utils_Request::retrieve('memberId', 'Positive', $this); | ||
| if (isset($memberShipId)) { | ||
| $this->_defaults['contribution_membership_id'] = $memberShipId; |
There was a problem hiding this comment.
Maybe fix the weird capitalisation of $memberShipId that was in the original? No boats here ...
aydun
approved these changes
Dec 3, 2019
|
Merging as per @aydun 's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a recent regression (5.19 I think) where all the contact's contributions rather than just thre relevant ones show on the Participant or Membership view pages
Before
All of a contact's contributions show
After
Just the ones relevant to the membership
Technical Details
I weighed up some more complex fixes but given it's an rc (& possibly a 5.19 backport) this seems safe & simple
Comments
@seamuslee001 @aydun