dev/core#1426 Return correct manager role info during Case api get

[demeritcowboy]

Overview

Case api get is supposed to return manager and creator flags in the 'contacts' element in the array. It stopped doing that in 5.16.

Before

Before 5.16:

                            [0] => Array
                                (
                                    [contact_id] => 2
                                    [display_name] => Something
                                    [sort_name] => Something
                                    [relationship_type_id] => 9
                                    [role] => Case Coordinator
                                    [email] => demo@example.com
                                    [phone] =>
                                    [creator] => 1
                                    [manager] => 1
                                )

5.16+

                            [0] => Array
                                (
                                    [contact_id] => 2
                                    [display_name] => Something
                                    [sort_name] => Something
                                    [relationship_type_id] => 9
                                    [role] => Case Coordinator is
                                    [email] => demo@example.com
                                    [phone] =>
                                )

After

                            [0] => Array
                                (
                                    [contact_id] => 2
                                    [display_name] => Something
                                    [sort_name] => Something
                                    [relationship_type_id] => 9
                                    [role] => Case Coordinator is
                                    [email] => demo@example.com
                                    [phone] =>
                                    [creator] => 1
                                    [manager] => 1
                                )

Technical Details

There is an existing unit test but it doesn't trigger because the role is no longer present so it doesn't even check. Have updated the test to additionally confirm the role is present. The test might still be problematic because "role" in the array is the label not the name so it's comparing against label, but leaving that out of this PR since the test is at least comparing against fixed things.

I reviewed where the api/manager info might elsewhere be used in a comment at https://lab.civicrm.org/dev/core/issues/1426#note_28318. It's mostly red herrings though so not reposting here.

Comments

Ping @tunbola @alifrumin @agh1

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[alifrumin]

• General standards
  • (r-explain) PASS described clearly
  • (r-user) PASS
  • (r-doc) PASS
  • (r-run) PASS I was able to replicate that there are no creator/manager flags in the contacts array when doing a case.get api call without this change HOWEVER they do appear with this change.
• Developer standards
  • (r-tech) PASS
  • (r-code) PASS
  • (r-maint) PASS
  • (r-test) PASS

@seamuslee001 this looks ready to be merged to me.

[demeritcowboy]

Thanks!