Code style, remove typo, double ;; from code where it makes sense to do so #16001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Dec 2, 2019
| @@ -13,7 +13,7 @@ | |||
| * <input type="text" value="{$profileId}" class="crm-profile-selector" /> | |||
| * ... | |||
| * cj('.crm-profile-selector').crmProfileSelector({ | |||
| * groupTypeFilter: "Contact,Individual,Activity;;ActivityType:7", | |||
There was a problem hiding this comment.
Are you sure about this one? It's neither javascript code nor php code. It's a data serialization notation.
There was a problem hiding this comment.
@colemanw it's also just a code comment - not executable code
Looked wrong to me, happy to revert if not wrong
There was a problem hiding this comment.
Agree it's a comment, but according to this code documentation it's actually correct using the double semicolon.
There was a problem hiding this comment.
@colemanw reverted that change
|
@jusfreeman looks good. Can you please squash your commits? |
jusfreeman
force-pushed
the
CIVICRM-1383
branch
from
cd8e3de
to
fe7f441
Compare
|
@yashodha done |
|
@jusfreeman Thanks! Will merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code style, remove typo, double ;; from code where it makes sense to do so.
As noted whilst reviewing #15937
Agileware Ref: CIVICRM-1383