Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] cleanup on QueryTest #15994

Merged
merged 1 commit into from
Nov 30, 2019
Merged

[NFC] cleanup on QueryTest #15994

merged 1 commit into from
Nov 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup only

Before

Use of double quotes, exceptions not declared, calling static fns non statically

After

Use of single quotes, exceptions declared, calling static fns statically

Technical Details

Comments

@civibot
Copy link

civibot bot commented Nov 29, 2019

(Standard links)

@civibot civibot bot added the master label Nov 29, 2019
@seamuslee001
Copy link
Contributor

test fails relate

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 2498e07 into civicrm:master Nov 30, 2019
@eileenmcnaughton eileenmcnaughton deleted the act_test branch November 30, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001