Make else statement more legible

[eileenmcnaughton]

Overview

Minor readability cleanup part of WTF-reduction regime

Before

We see the equivalent of

if ($a or $b) {
  $x = 1;
}
elseif ($value == '0' || $value !== '') {
 $x = 2;
}
else {
  $x = 1;
}

The 2 statements in the second part overlap - ie if value == 0 is redundant & the final else only applies when $value !== ''

After

We see the equivalent of

if ($a or $b  || $value !== '') {
  $x = 1;
}
else  {
 $x = 2;
}

Technical Details

This just condenses the statement since != '' is so broad we know the final
else is only when that is true - ergo it's the same as above

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Makes sense to me merging