Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] clean up merge array. #15970

Merged
merged 1 commit into from
Dec 2, 2019
Merged

[REF] clean up merge array. #15970

merged 1 commit into from
Dec 2, 2019

Commits on Nov 27, 2019

  1. [REF] clean up merge array. 

    This code has been doing my head in because it is just like 'construct complex array & then another
complex array & iterate them together in nasty ways.

However, after another round of misery I'm pretty sure that this cleanup works. Basically the whole removed
section of code amounts to 'the array built in the first pass takes precedence over the one in the
second pass'. By using a property & only setting the array values when not-yet-set we can
allow the second pass to not clobber the first while populating it rather than as follow up wrangling
    @eileenmcnaughton
    eileenmcnaughton committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    0b743fb View commit details
    Browse the repository at this point in the history