Remove unused parameter #15953
Merged
Remove unused parameter #15953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 3 calls to writeCSVFile - none of them pass in saveFile so it can be removed
|
(Standard links)
|
|
There is a small risk that it could impact extensions, but I did a quick search and could not find any. Seems OK to merge. Will wait a bit in case anyone else has feedback. |
|
Yeah extensions should be using clever libraries not hacky non-api functions for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a parameter that is unused
Before
There are 3 calls to writeCSVFile - none of them pass in saveFile but it is available as an option
After
$saveFile parameter removed
Technical Details
Comments
The function called is hard going & can be replaced by our phpleague package once the inputs & outputs make sense