Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Export: Add deprecation warning #15951

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Adds a deprecation warning on code I believe to be unreachable

Before

After

A deprecation message would show up (on dev sites) if this code is ever hit

Technical Details

On digging into this export function I cannot find any way to access these lines.

If no-one else can spot a way I propose adding a deprecation notice & later removing

Comments

On digging into this export function I cannot find any way to access these lines.

If no-one else can spot a way I propose adding a deprecation notice & later removing
@civibot
Copy link

civibot bot commented Nov 25, 2019

(Standard links)

@civibot civibot bot added the master label Nov 25, 2019
@mlutfy mlutfy changed the title Add deprecation warning. CSV Export: Add deprecation warning Nov 25, 2019
@mlutfy mlutfy merged commit ea8f686 into civicrm:master Nov 27, 2019
@mlutfy
Copy link
Member

mlutfy commented Nov 27, 2019

Merge based on code review, and quick look at the code. I am not sure I understand the code, and the deprecation warning will help us understand/cleanup.

@eileenmcnaughton eileenmcnaughton deleted the export_bom branch November 27, 2019 19:20
@eileenmcnaughton
Copy link
Contributor Author

Lol - I'm sure I don't understand the code :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants