Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort CMS Database Table list #15944

Merged

Conversation

magnolia61
Copy link
Contributor

Overview

Sort the CMS Database Tables list (the one for settings.php) for more clarity

Before

The CMS Database Tables list to be included in settings.php was not sorted.

After

The CMS Database Tables list to be included in settings.php was is sorted alphabetically.

Technical Details

simple array sort

Comments

@civibot
Copy link

civibot bot commented Nov 24, 2019

(Standard links)

@civibot civibot bot added the master label Nov 24, 2019
@eileenmcnaughton
Copy link
Contributor

I can't replicate this not being sorted but can imagine it is mysql version or config or MariaDB related & on testing this doesn't cause any problems for me & I can see it could be useful.

I pondered whether we should change the called function to add an order by since it's likely it does that implicitly on some versions of mysql & not others. But on balance this feels pretty light weight & OK as is

@eileenmcnaughton eileenmcnaughton merged commit 7111909 into civicrm:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants