[REF] Move wrangling of Front end form contribution param for autoRenew back to form

[eileenmcnaughton]

Overview

Refactoring towards cleaning up processAmount function

Before

$component is a param that is code for 'add autoRenew elements to the array'

After

$component is no longer a param. The places where this is needed are now calculated on the form

Technical Details

The processAmount function is really problematic because it's trying to do several disparate things & is called from
all over the place with unclear intent. From looking at it I see it does a few things. It reformats line items,
it does some obscure & likely flawed filtering, it generates a total cost & a tax cost and it generates a very
specifically formatted array of autoreneal properties,

The way I see this going is

1. Move the formatting of the autorenewal back to the calling form (this PR) & simplify it
2. Split out the foreach so it goes through once & formats - this can be shoved out to a separate function

• and then it goes through the formatted array & calculates total_amount & tax_amount - we should
  have a wrapper function that just returns these & we might see that is most of what is needed

3. Move all that awful partial_payment_total stuff back to the event form. Note that we are working
   to entirely remove that from here are it makes so much less than no sense.
4. Calculates amount_level text - that should have it's own function.

It worth noting all of this does very little intensive work - a DB lookup or 2 that could be cached & an iteration
through a very small array so it would be fine to have 3 functions -

• getAmountTotal
• getTaxTotal
• getAmountText

that each go through the same process of generating a formatted array from price_x => 5 etc rather than trying
to pass the array around for 'performance' or to 'save work'.

From previous refactorings I would suggest we add an Order class such as eileenmcnaughton@6d60f4f where by you set the price fields
& then you can call 'getLineItems' - but that is a few steps after this....

Comments

@seamuslee001 @monishdeb @mattwire I'm hoping some combination of you can help work through this with me. I think that once we have a function to getTotalAmount from a set of price set params we'll be in a much better place to clean up a bunch of code. The confusion around passing things like line item by reference & why we have to pass in 'fields' & where that comes from has been holding us back IMHO

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire @seamuslee001 @monishdeb it would be nice to get this clean up merged - it does help simplify a rather nasty function

[seamuslee001]

This looks right and i think the code change makes sense to me and seems a sensible consolidation and we have plenty of tests i believe covering auto renew so i think we can merge this based on the tests passing