[REF] Convert CRM_Core_Error::fatal to CRM_Core_Error::statusBounce i… #15863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Extension/Downloader.php
Outdated
| @@ -105,7 +105,7 @@ public function download($key, $downloadUrl) { | |||
| $destDir = $this->containerDir . DIRECTORY_SEPARATOR . $key; | |||
|
|
|||
| if (!$downloadUrl) { | |||
| CRM_Core_Error::fatal(ts('Cannot install this extension - downloadUrl is not set!')); | |||
| CRM_Core_Error::statusBounce(ts('Cannot install this extension - downloadUrl is not set!')); | |||
There was a problem hiding this comment.
is this the form - otherwise an exception makes sense
|
@seamuslee001 were you going to update this to throw exceptions? |
seamuslee001
force-pushed
the
status_bounce_extension
branch
from
4b1fdf5
to
df9f2d1
Compare
|
done @eileenmcnaughton |
| @@ -105,7 +105,7 @@ public function download($key, $downloadUrl) { | |||
| $destDir = $this->containerDir . DIRECTORY_SEPARATOR . $key; | |||
|
|
|||
| if (!$downloadUrl) { | |||
| CRM_Core_Error::fatal(ts('Cannot install this extension - downloadUrl is not set!')); | |||
| throw new CRM_Extension_Exception(ts('Cannot install this extension - downloadUrl is not set!')); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n Extension folder
Overview
This converts from deprecated function
CRM_Core_Error::fatalto usingCRM_Core_Error::statusBounceBefore
Deprecated function used in the Extensions subsystem
After
Non depreacted function used
ping @yashodha @eileenmcnaughton