Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] dev/core#1394 - Avoid duplicate activity types in tests that use CiviCaseTestCase #15853

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Nov 15, 2019

Overview

https://lab.civicrm.org/dev/core/issues/1394
CiviCaseTestCase can create duplicate option values in setup() so you can end up with multiple activity type option values with the same name.

@civibot
Copy link

civibot bot commented Nov 15, 2019

(Standard links)

@civibot civibot bot added the master label Nov 15, 2019
@demeritcowboy demeritcowboy force-pushed the civicasetestcase-duplicate-option-values branch from e11582a to 244a19f Compare November 15, 2019 13:06
@demeritcowboy demeritcowboy changed the title [WIP][TEST] dev/core#1394 - Avoid duplicate activity types in tests that use CiviCaseTestCase [TEST] dev/core#1394 - Avoid duplicate activity types in tests that use CiviCaseTestCase Nov 15, 2019
@demeritcowboy demeritcowboy force-pushed the civicasetestcase-duplicate-option-values branch from 244a19f to 0ca4b20 Compare November 15, 2019 15:46
@seamuslee001
Copy link
Contributor

This only affects tests and Jenkins is good with it then so am i

@seamuslee001 seamuslee001 merged commit 4769013 into civicrm:master Nov 17, 2019
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the civicasetestcase-duplicate-option-values branch November 17, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants