[NFC] Add in unit test of code being altered by #15826 #15849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
dev_core_183_dedupe_test
branch
from
3216b54 to
d5461db
Compare
|
OK - yes take out the exception & we can merge this! |
seamuslee001
force-pushed
the
dev_core_183_dedupe_test
branch
from
d5461db to
197e72c
Compare
|
done @eileenmcnaughton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eileenmcnaughton this adds in a unit test for the last part of #15826 that isn't aready covered by a unit test. Note that the unit test will fail on the first run due to the Exception being thrown