-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(NFC) (dev/core#878) Simplify standard header. Remove year+version. #15843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Standard links)
|
-47K LoC 👍 Please report back on bandwidth savings from CiviCRM.org/download |
I approve this change 👍 |
gasps and smiles Fantastic! |
totten
force-pushed
the
master-simplehead
branch
from
November 13, 2019 23:34
38016d0
to
ca61d27
Compare
totten
force-pushed
the
master-simplehead
branch
from
November 14, 2019 00:11
ca61d27
to
bc77d7c
Compare
totten
changed the title
(NFC) (dev/core#878) Simplify standard header - Remove year+version
(NFC) (dev/core#878) Simplify standard header. Remove year+version.
Nov 14, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This implements https://lab.civicrm.org/dev/core/issues/878 and aims to reduce git-noise.
Before
After
Comments
As you can see in 878, the comparable headers among other reputable projects are varied. They (almost always?) include the copyright declaration and some reference to the license terms; but they differ on whether to include specific version numbers and years in the declaration. However, this means that there are good precendents (such as Google's Angular and Facebook's React) which use a convention similar to this updated one.
This PR only changes files which already use the standard header (modulo trivial formatting). The bulk of the switch was performed with https://gist.github.com/totten/85d368a512f7dcda9319dfb57a0f8ecf, though a handful of files (which had trivial formatting differences) were manually tweaked.