Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api explorer formatting IS NULL clauses #15817

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix api explorer formatting IS NULL clauses #15817

merged 1 commit into from
Nov 19, 2019

Conversation

colemanw
Copy link
Member

Overview

Fixes a formatting issue in the api explorer output where IS NULL and IS NOT NULL clauses would output invalid code due to the missing value piece of the clause.

Before

image

After

image

@civibot
Copy link

civibot bot commented Nov 11, 2019

(Standard links)

@civibot civibot bot added the master label Nov 11, 2019
@colemanw
Copy link
Member Author

@civicrm-builder retest this please

@demeritcowboy
Copy link
Contributor

Did a little r-run. Looks good to me and also fixes = '' which would previously display as = null.

@seamuslee001
Copy link
Contributor

Merging as per review by @demeritcowboy

@seamuslee001 seamuslee001 merged commit b46379c into civicrm:master Nov 19, 2019
@colemanw colemanw deleted the Fix branch January 31, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colemanw @demeritcowboy @seamuslee001