dev/core#1371 Fix e-notice caused by trying to pass in known to the … #15762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtension downloader when checking requirements
|
(Standard links)
|
|
will you do a 5.19 pr too? |
|
@eileenmcnaughton i can do |
|
The relevant gitlab issue is here: https://lab.civicrm.org/dev/core/issues/1371 (Aha I see this is referenced in the title :) ) |
|
@eileenmcnaughton 5.19 port is here #15763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…extension downloader when checking requirements
Overview
This fixes an e-noticed reported by @stesi561 when running cv ext:download
Before
E-notice
After
no e-notice
ping @eileenmcnaughton @mattwire