Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dev/core#1065) Contribution in Edit mode needs to be shown consistently #15757

Merged
merged 1 commit into from
Nov 8, 2019
Merged

(dev/core#1065) Contribution in Edit mode needs to be shown consistently #15757

merged 1 commit into from
Nov 8, 2019

Conversation

yashodha
Copy link
Contributor

@yashodha yashodha commented Nov 7, 2019

Overview

Contribution in Edit mode needs to be shown in consistency with Grant/Member/Participant screens.

Before

Display name is hardcoded freeze value
contri_before

After

Display name is clickable contact name.

contri_after

@civibot
Copy link

civibot bot commented Nov 7, 2019

(Standard links)

@civibot civibot bot added the master label Nov 7, 2019
jitendrapurohit
jitendrapurohit approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and confirm that it works as mentioned in the description.

@yashodha
Copy link
Contributor Author

yashodha commented Nov 8, 2019

@jitendrapurohit thanks! merging this now as per your confirmation

@yashodha yashodha merged commit 52c1f17 into civicrm:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendrapurohit jitendrapurohit jitendrapurohit approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashodha @jitendrapurohit