[REF] very minor tidy up #15756
Merged
[REF] very minor tidy up #15756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
yashodha
reviewed
Nov 7, 2019
CRM/Dedupe/Merger.php
Outdated
| $rows["move_$field"] = [ | ||
| 'main' => self::getFieldValueAndLabel($field, $main)['label'], | ||
| 'other' => self::getFieldValueAndLabel($field, $other)['label'], | ||
| 'title' => $fields[$field]['title'] |
There was a problem hiding this comment.
@eileenmcnaughton A comma should follow the last multiline array item.
This just brings the 3 lines that built this 'array within an array' together & makes them a little more readable
eileenmcnaughton
force-pushed
the
qfbug
branch
from
b475dbb
to
1ce8730
Compare
|
@eileenmcnaughton merging this |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This just brings the 3 lines that built this 'array within an array' together & makes them a little more
readable
Before
Code confusing
After
Still confusing
Technical Details
Comments